Upgrade github.com/modelcontextprotocol/go-sdk to fix DNS rebinding vulnerability#172
Merged
Merged
Conversation
github.com/modelcontextprotocol/go-sdk to fix DNS rebinding vulnerability
murrayju
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades
github.com/modelcontextprotocol/go-sdkfromv1.2.0tov1.6.1.v1.2.0did not enable DNS rebinding protection by default for HTTP-based MCP servers, which let a malicious website reach the local Tiger MCP HTTP server (tiger mcp start http) and invoke Tiger Cloud tools using the server-held credentials. The SDK enabled localhost DNS rebinding protection by default as ofv1.4.0, so this is fixed by the version bump alone — no source changes are needed. Requests arriving on a loopback address with a non-localhostHostheader (the shape of a rebound browser request) are now rejected with403, while legitimate localhost clients are unaffected.See the go-sdk
v1.4.0release notes (under "Introduced DNS rebinding protection") for details on the upstream fix: https://github.com/modelcontextprotocol/go-sdk/releases/tag/v1.4.0